Fix erroneous order of events for multi events per listener #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acran
suggested changes
Jun 6, 2025
| $id = $reference->__toString(); | ||
| foreach ($container->getDefinition($id)->getTag('doctrine.orm.entity_listener') as $attributes) { | ||
| foreach ($container->findTaggedServiceIds('doctrine.orm.entity_listener') as $id => $tags) { | ||
| usort($tags, static fn (array $a, array $b) => ($a['priority'] ?? 0) <=> ($b['priority'] ?? 0)); |
There was a problem hiding this comment.
should be
Suggested change
| usort($tags, static fn (array $a, array $b) => ($a['priority'] ?? 0) <=> ($b['priority'] ?? 0)); | |
| usort($tags, static fn (array $a, array $b) => ($b['priority'] ?? 0) <=> ($a['priority'] ?? 0)); |
i.e. tags with a larger number as priority come first!?
| foreach ($resolvers as $reference) { | ||
| $id = $reference->__toString(); | ||
| foreach ($container->getDefinition($id)->getTag('doctrine.orm.entity_listener') as $attributes) { | ||
| foreach ($container->findTaggedServiceIds('doctrine.orm.entity_listener') as $id => $tags) { |
There was a problem hiding this comment.
The next line will sort the tags within the service by priority but the services are now simply in the order they are returned by $container->findTaggedServiceIds(), i.e., in the order they were defined.
But for the listeners to be registered in the correct order the tags of all services need to be ordered together.
This probably needs to restructure the code to a single foreach over all tags of all returned services?
There was a problem hiding this comment.
So something like this:
$serviceTags = [];
foreach ($container->findTaggedServiceIds('doctrine.orm.entity_listener') as $id => $tags) {
foreach ($tags as $attributes) {
$serviceTags[] = [
'serviceId' => $id,
'attributes' => $attributes,
];
}
}
usort($serviceTags, static fn (array $a, array $b) => ($b['attributes']['priority'] ?? 0) <=> ($a['attributes']['priority'] ?? 0));
foreach ($serviceTags as $tag) {
$id = $tag['serviceId'];
$attributes = $tag['attributes'];There was a problem hiding this comment.
Test I have added doesn't pass with such a change. Mind raising a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1884